Reviewers: Michael Achenbach,

Description:
Fix building android gn

BUG=none
[email protected]
LOG=n

Please review this at https://codereview.chromium.org/313923002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+7, -5 lines):
  M BUILD.gn


Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 2caf0c0fc391a3f05ba65f7f8889acbb3dca1606..2fe4579f15e73e132de3f4f652642ec52f519229 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -976,8 +976,14 @@ executable("mksnapshot") {
     ":v8_nosnapshot",
   ]

+  libs = []
+
   if (v8_compress_startup_data == "bz2") {
-    libs = [ "bz2" ]
+    libs += [ "bz2" ]
+  }
+
+  if (is_android && current_toolchain != host_toolchain) {
+    libs += [ "log" ]
   }
 }

@@ -1004,10 +1010,6 @@ component("v8") {
     ]
   }

-  if (is_android && current_toolchain != host_toolchain) {
-    libs = [ "log" ]
-  }
-
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
   configs += [ ":internal_config", ":features", ":toolchain" ]


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to