lgtm with nits:
https://codereview.chromium.org/316023002/diff/20001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/316023002/diff/20001/src/hydrogen-instructions.cc#newcode4643
src/hydrogen-instructions.cc:4643: case
AllocationSite::kTransitionInfoOffset:
While we are here, does it make sense to merge common cases together?
https://codereview.chromium.org/316023002/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/316023002/diff/20001/src/hydrogen.cc#newcode10499
src/hydrogen.cc:10499: BuildEmitObjectHeader(boilerplate_object,
object);
I think it is better to move BuildEmitObjectHeader() before the "If
allocation ..." comment above.
https://codereview.chromium.org/316023002/diff/20001/src/hydrogen.cc#newcode10501
src/hydrogen.cc:10501: empty_fixed_array, INITIALIZING_STORE);
I think it is cleaner not to pass INITIALIZING_STORE explicitly here as
it is the default value.
https://codereview.chromium.org/316023002/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/316023002/diff/20001/src/objects.h#newcode6329
src/objects.h:6329: return static_cast<uint32_t>(instance_type()) >=
FIRST_JS_OBJECT_TYPE;
I think you can use IsJSObjectMap() predicate here and probably in all
other places where we do similar instance type comparison.
https://codereview.chromium.org/316023002/diff/20001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/316023002/diff/20001/src/x64/lithium-codegen-x64.cc#newcode3054
src/x64/lithium-codegen-x64.cc:3054: // Load backing store length, with
implicit Smi untagging.
STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);
https://codereview.chromium.org/316023002/diff/20001/src/x64/lithium-codegen-x64.cc#newcode3093
src/x64/lithium-codegen-x64.cc:3093: // Don't use UNKNOWN_PURPOSE.
default:
https://codereview.chromium.org/316023002/diff/20001/src/x64/lithium-codegen-x64.cc#newcode3255
src/x64/lithium-codegen-x64.cc:3255: // Load elements length, with
implicit Smi untagging.
STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);
https://codereview.chromium.org/316023002/diff/20001/src/x64/lithium-codegen-x64.cc#newcode4258
src/x64/lithium-codegen-x64.cc:4258:
Extra empty line?
https://codereview.chromium.org/316023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
