Reviewers: mvstanton,
Message:
Committed patchset #1 manually as r21699 (presubmit successful).
Description:
Fix presubmit warning.
(http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/8147/steps/Presubmit/logs/stdio)
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=21699
Please review this at https://codereview.chromium.org/319563003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -5 lines):
M src/d8.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
4ed4f76c34fbf6004d37361f016e5e2ed8453203..7c1230032c5e2b660c114d20da2d5e712b77b31a
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1310,25 +1310,23 @@ bool Shell::SetOptions(int argc, char* argv[]) {
} else if (strncmp(argv[i], "--icu-data-file=", 16) == 0) {
options.icu_data_file = argv[i] + 16;
argv[i] = NULL;
- }
#ifdef V8_SHARED
- else if (strcmp(argv[i], "--dump-counters") == 0) {
+ } else if (strcmp(argv[i], "--dump-counters") == 0) {
printf("D8 with shared library does not include counters\n");
return false;
} else if (strcmp(argv[i], "--debugger") == 0) {
printf("Javascript debugger not included\n");
return false;
- }
#endif // V8_SHARED
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
- else if (strncmp(argv[i], "--natives_blob=", 15) == 0) {
+ } else if (strncmp(argv[i], "--natives_blob=", 15) == 0) {
options.natives_blob = argv[i] + 15;
argv[i] = NULL;
} else if (strncmp(argv[i], "--snapshot_blob=", 16) == 0) {
options.snapshot_blob = argv[i] + 16;
argv[i] = NULL;
- }
#endif // V8_USE_EXTERNAL_STARTUP_DATA
+ }
}
v8::V8::SetFlagsFromCommandLine(&argc, argv, true);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
