Status: New
Owner: ----
CC: [email protected], [email protected]
Labels: Type-Bug Priority-Medium
New issue 3376 by [email protected]: Presubmit lint check triggers on
unrelated changes
http://code.google.com/p/v8/issues/detail?id=3376
In attempting to land https://codereview.chromium.org/313153002/ (which is
a one-line change to flag-definitions.h), I get the following lint error
from git cl dcommit:
Running presubmit commit checks ...
/src/chromium/src/v8/include/v8-util.h:312: Is this a non-const reference?
If so, make const or use a pointer: ReturnValue<Value>& returnValue
[runtime/references] [2]
Done processing /src/chromium/src/v8/include/v8-util.h
Total errors found: 1
Total violating files: 0
** Presubmit ERRORS **
C++ lint check failed
Seems like the lint check should only apply to files (and ideally lines)
that were modified by the patch. My memory is that it used to work this
way; did something change recently?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
