Revision: 21707
Author:   [email protected]
Date:     Fri Jun  6 08:15:05 2014 UTC
Log:      Fix bug in tools/plot-timer-events

Bug was introduced in r21338.

[email protected]

Review URL: https://codereview.chromium.org/314143004
http://code.google.com/p/v8/source/detail?r=21707

Modified:
 /branches/bleeding_edge/src/bootstrapper.cc
 /branches/bleeding_edge/tools/plot-timer-events
 /branches/bleeding_edge/tools/profviz/composer.js

=======================================
--- /branches/bleeding_edge/src/bootstrapper.cc Tue Jun  3 11:52:07 2014 UTC
+++ /branches/bleeding_edge/src/bootstrapper.cc Fri Jun  6 08:15:05 2014 UTC
@@ -1071,7 +1071,7 @@
     native_context()->set_json_object(*json_object);
   }

-  { // -- A r r a y B u f f e r
+  {  // -- A r r a y B u f f e r
     Handle<JSFunction> array_buffer_fun =
         InstallFunction(
             global, "ArrayBuffer", JS_ARRAY_BUFFER_TYPE,
@@ -1081,7 +1081,7 @@
     native_context()->set_array_buffer_fun(*array_buffer_fun);
   }

-  { // -- T y p e d A r r a y s
+  {  // -- T y p e d A r r a y s
#define INSTALL_TYPED_ARRAY(Type, type, TYPE, ctype, size) \ { \ Handle<JSFunction> fun; \
=======================================
--- /branches/bleeding_edge/tools/plot-timer-events Fri May 16 13:04:45 2014 UTC +++ /branches/bleeding_edge/tools/plot-timer-events Fri Jun 6 08:15:05 2014 UTC
@@ -15,7 +15,7 @@
   if test -x "$d8_public"; then D8_PATH=$(dirname "$d8_public"); fi
 fi

-if test -n "$D8_PATH"; then
+if test ! -n "$D8_PATH"; then
   D8_PATH=$tools_path/..
 fi

=======================================
--- /branches/bleeding_edge/tools/profviz/composer.js Fri Sep 27 13:45:17 2013 UTC +++ /branches/bleeding_edge/tools/profviz/composer.js Fri Jun 6 08:15:05 2014 UTC
@@ -502,7 +502,8 @@
     execution_pauses.sort(
         function(a, b) { return b.duration() - a.duration(); });

-    var max_pause_time = execution_pauses[0].duration();
+    var max_pause_time = execution_pauses.length > 0
+        ? execution_pauses[0].duration() : 0;
     padding = kPauseLabelPadding * (range_end - range_start) / kResX;
     var y_scale = kY1Offset / max_pause_time / 2;
for (var i = 0; i < execution_pauses.length && i < kNumPauseLabels; i++) {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to