Reviewers: Jakob,
Description:
Log IC misses as timer events.
[email protected]
Please review this at https://codereview.chromium.org/318983005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+39, -1 lines):
M src/ic.cc
M src/log.h
M src/log.cc
M tools/profviz/composer.js
M tools/profviz/stdio.js
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index
0040b1d352f2ac1a43c92a1f1f55c67dd283a50d..07745378a3c6f6bb80e531224a80231cd01fd4a6
100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1917,6 +1917,8 @@ void CallIC::HandleMiss(Handle<Object> receiver,
// Used from ic-<arch>.cc.
RUNTIME_FUNCTION(CallIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 4);
CallIC ic(isolate);
@@ -1930,6 +1932,8 @@ RUNTIME_FUNCTION(CallIC_Miss) {
RUNTIME_FUNCTION(CallIC_Customization_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 4);
// A miss on a custom call ic always results in going megamorphic.
@@ -1944,6 +1948,8 @@ RUNTIME_FUNCTION(CallIC_Customization_Miss) {
// Used from ic-<arch>.cc.
RUNTIME_FUNCTION(LoadIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 2);
LoadIC ic(IC::NO_EXTRA_FRAME, isolate);
@@ -1958,6 +1964,8 @@ RUNTIME_FUNCTION(LoadIC_Miss) {
// Used from ic-<arch>.cc
RUNTIME_FUNCTION(KeyedLoadIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 2);
KeyedLoadIC ic(IC::NO_EXTRA_FRAME, isolate);
@@ -1971,6 +1979,8 @@ RUNTIME_FUNCTION(KeyedLoadIC_Miss) {
RUNTIME_FUNCTION(KeyedLoadIC_MissFromStubFailure) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 2);
KeyedLoadIC ic(IC::EXTRA_CALL_FRAME, isolate);
@@ -1985,6 +1995,8 @@ RUNTIME_FUNCTION(KeyedLoadIC_MissFromStubFailure) {
// Used from ic-<arch>.cc.
RUNTIME_FUNCTION(StoreIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 3);
StoreIC ic(IC::NO_EXTRA_FRAME, isolate);
@@ -2001,6 +2013,8 @@ RUNTIME_FUNCTION(StoreIC_Miss) {
RUNTIME_FUNCTION(StoreIC_MissFromStubFailure) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 3);
StoreIC ic(IC::EXTRA_CALL_FRAME, isolate);
@@ -2017,6 +2031,8 @@ RUNTIME_FUNCTION(StoreIC_MissFromStubFailure) {
RUNTIME_FUNCTION(StoreIC_ArrayLength) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 2);
@@ -2043,6 +2059,8 @@ RUNTIME_FUNCTION(StoreIC_ArrayLength) {
// it is necessary to extend the properties array of a
// JSObject.
RUNTIME_FUNCTION(SharedStoreIC_ExtendStorage) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope shs(isolate);
ASSERT(args.length() == 3);
@@ -2083,6 +2101,8 @@ RUNTIME_FUNCTION(SharedStoreIC_ExtendStorage) {
// Used from ic-<arch>.cc.
RUNTIME_FUNCTION(KeyedStoreIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 3);
KeyedStoreIC ic(IC::NO_EXTRA_FRAME, isolate);
@@ -2099,6 +2119,8 @@ RUNTIME_FUNCTION(KeyedStoreIC_Miss) {
RUNTIME_FUNCTION(KeyedStoreIC_MissFromStubFailure) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 3);
KeyedStoreIC ic(IC::EXTRA_CALL_FRAME, isolate);
@@ -2149,6 +2171,8 @@ RUNTIME_FUNCTION(KeyedStoreIC_Slow) {
RUNTIME_FUNCTION(ElementsTransitionAndStoreIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 4);
KeyedStoreIC ic(IC::EXTRA_CALL_FRAME, isolate);
@@ -2658,6 +2682,8 @@ MaybeHandle<Object> BinaryOpIC::Transition(
RUNTIME_FUNCTION(BinaryOpIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT_EQ(2, args.length());
Handle<Object> left = args.at<Object>(BinaryOpICStub::kLeft);
@@ -2673,6 +2699,8 @@ RUNTIME_FUNCTION(BinaryOpIC_Miss) {
RUNTIME_FUNCTION(BinaryOpIC_MissWithAllocationSite) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT_EQ(3, args.length());
Handle<AllocationSite> allocation_site = args.at<AllocationSite>(
@@ -2906,6 +2934,8 @@ Code* CompareIC::UpdateCaches(Handle<Object> x,
Handle<Object> y) {
// Used from ICCompareStub::GenerateMiss in code-stubs-<arch>.cc.
RUNTIME_FUNCTION(CompareIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
ASSERT(args.length() == 3);
CompareIC ic(isolate, static_cast<Token::Value>(args.smi_at(2)));
@@ -2970,6 +3000,8 @@ Handle<Object>
CompareNilIC::CompareNil(Handle<Object> object) {
RUNTIME_FUNCTION(CompareNilIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
HandleScope scope(isolate);
Handle<Object> object = args.at<Object>(0);
CompareNilIC ic(isolate);
@@ -3035,6 +3067,8 @@ Handle<Object> ToBooleanIC::ToBoolean(Handle<Object>
object) {
RUNTIME_FUNCTION(ToBooleanIC_Miss) {
+ Logger::TimerEventScope timer(
+ isolate, Logger::TimerEventScope::v8_ic_miss);
ASSERT(args.length() == 1);
HandleScope scope(isolate);
Handle<Object> object = args.at<Object>(0);
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index
76d7b6f59a063e9e20c8f1032aee26ace92cc623..f6dfd2161d89b425c89b97f741acf8a3160b3a05
100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1129,6 +1129,7 @@ const char*
Logger::TimerEventScope::v8_compile_full_code =
"V8.CompileFullCode";
const char* Logger::TimerEventScope::v8_execute = "V8.Execute";
const char* Logger::TimerEventScope::v8_external = "V8.External";
+const char* Logger::TimerEventScope::v8_ic_miss = "V8.IcMiss";
void Logger::LogRegExpSource(Handle<JSRegExp> regexp) {
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index
c4057f1aa785dc8a69bc72d9c72128ffd5b0c375..68e0a6cb6eeb03e4b46162fba639dbc27d7ff5d2
100644
--- a/src/log.h
+++ b/src/log.h
@@ -318,6 +318,7 @@ class Logger {
static const char* v8_compile_full_code;
static const char* v8_execute;
static const char* v8_external;
+ static const char* v8_ic_miss;
private:
Isolate* isolate_;
Index: tools/profviz/composer.js
diff --git a/tools/profviz/composer.js b/tools/profviz/composer.js
index
f9b3f2e916c8756e9c78fae9375d99b130e17e27..bd9fc18a233ce6229ad9df3b4d7abec722ae3327
100644
--- a/tools/profviz/composer.js
+++ b/tools/profviz/composer.js
@@ -105,6 +105,8 @@ function PlotScriptComposer(kResX, kResY, error_output)
{
new TimerEvent("recompile async", "#CC4499", false, 1),
'V8.CompileEval':
new TimerEvent("compile eval", "#CC4400", true, 0),
+ 'V8.IcMiss':
+ new TimerEvent("ic miss", "#CC9900", true, 0),
'V8.Parse':
new TimerEvent("parse", "#00CC00", true, 0),
'V8.PreParse':
Index: tools/profviz/stdio.js
diff --git a/tools/profviz/stdio.js b/tools/profviz/stdio.js
index
db38f042a7d016efb95e9d6803e8f59593920c83..5a8311dfb2835739c06b043535f1b26220f91ec5
100644
--- a/tools/profviz/stdio.js
+++ b/tools/profviz/stdio.js
@@ -43,7 +43,7 @@ if (!isNaN(range_start)) range_start_override =
range_start;
if (!isNaN(range_end)) range_end_override = range_end;
var kResX = 1600;
-var kResY = 600;
+var kResY = 700;
function log_error(text) {
print(text);
quit(1);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
