Yes, it was fine. In the future, if you want to be sure, you can run:
tools/presubmit.py
before uploading your cl if you want to make sure your CL conforms to the
style
guide (git-cl upload does this automatically). If there are blatant style
violations, the tool will report them.
FYI: In the near future, we plan on making clang-format the standard for
our V8
code formatting, when that happens we'll add formatting compliance to the
presubmit test as well.
https://codereview.chromium.org/314123003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
