Feedback addressed, landing.
https://codereview.chromium.org/300283002/diff/180001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/300283002/diff/180001/src/code-stubs.h#newcode935
src/code-stubs.h:935:
EncodedLoadFieldByIndexBits::encode(property_index_key);
On 2014/06/06 12:00:32, Toon Verwaest wrote:
4-space indent
Done.
https://codereview.chromium.org/300283002/diff/180001/src/field-index-inl.h
File src/field-index-inl.h (right):
https://codereview.chromium.org/300283002/diff/180001/src/field-index-inl.h#newcode18
src/field-index-inl.h:18: return FieldIndex(true, index, false, index +
1, 0, true);
On 2014/06/06 12:00:33, Toon Verwaest wrote:
Since you have the map, what about just calculating the proper number
of
inobject properties? Otherwise confusing bugs might pop up if someone
starts
using this fake value.
In this case, we don't have the map (it's NULL). This is the case where
we have a hard coded offset into a hidden field in a class, e.g. string
length. Added some ASSERTs and a better default value.
https://codereview.chromium.org/300283002/diff/180001/src/field-index-inl.h#newcode21
src/field-index-inl.h:21: (map->inobject_properties() * kPointerSize);
On 2014/06/06 12:00:33, Toon Verwaest wrote:
What about a helper method: first_inobject_offset(Map* map);
Done.
https://codereview.chromium.org/300283002/diff/180001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/300283002/diff/180001/src/objects-inl.h#newcode1946
src/objects-inl.h:1946: // Adjust for the number of properties stored in
the object.
On 2014/06/06 12:00:33, Toon Verwaest wrote:
Remove leftover comment
Done.
https://codereview.chromium.org/300283002/diff/180001/src/objects-inl.h#newcode1956
src/objects-inl.h:1956: // Adjust for the number of properties stored in
the object.
On 2014/06/06 12:00:33, Toon Verwaest wrote:
Same as above
Done.
https://codereview.chromium.org/300283002/diff/180001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/300283002/diff/180001/src/stub-cache.cc#newcode970
src/stub-cache.cc:970: if (field.index() == 643) {
On 2014/06/06 12:00:33, Toon Verwaest wrote:
What? :)
Done.
https://codereview.chromium.org/300283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
