Lgtm with a couple of suggestions. Thanks.
https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc
File src/arm64/assembler-arm64.cc (right):
https://codereview.chromium.org/318773009/diff/1/src/arm64/assembler-arm64.cc#newcode1482
src/arm64/assembler-arm64.cc:1482: Emit(LoadLiteralOpFor(rt) |
ImmLLiteral(imm19) | Rt(rt));
How about having the argument be a byte offset from PC (like the old
LoadLiteral). This seems clearer to me. WDYT?
https://codereview.chromium.org/318773009/diff/1/src/arm64/macro-assembler-arm64.h
File src/arm64/macro-assembler-arm64.h (right):
https://codereview.chromium.org/318773009/diff/1/src/arm64/macro-assembler-arm64.h#newcode397
src/arm64/macro-assembler-arm64.h:397: // Load a literal from an inline
pool.
Nit, "Load a literal from the inline constant pool."
https://codereview.chromium.org/318773009/diff/1/src/arm64/macro-assembler-arm64.h#newcode399
src/arm64/macro-assembler-arm64.h:399: // helper function for double
immediate.
nit - Helper
https://codereview.chromium.org/318773009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
