Reviewers: Yang,
Description:
Reuse RelocInfo's IsPatchedDebugBreakSlotSequence() implementation.
RelocInfo::IsPatchedDebugBreakSlotSequence() already does this assembly
check, so just reuse it in BreakLocationIterator::IsDebugBreakAtSlot(),
like the other debug ports do.
BUG=None
TEST=None
[email protected]
Please review this at https://codereview.chromium.org/321743002/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/x64/debug-x64.cc
Index: src/x64/debug-x64.cc
diff --git a/src/x64/debug-x64.cc b/src/x64/debug-x64.cc
index
bdb9e51202303a1beb72eb8858b62d31bc3378ea..4703e42354746586dfc2558173d0563089800493
100644
--- a/src/x64/debug-x64.cc
+++ b/src/x64/debug-x64.cc
@@ -48,7 +48,7 @@ bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo*
rinfo) {
bool BreakLocationIterator::IsDebugBreakAtSlot() {
ASSERT(IsDebugBreakSlot());
// Check whether the debug break slot instructions have been patched.
- return !Assembler::IsNop(rinfo()->pc());
+ return rinfo()->IsPatchedDebugBreakSlotSequence();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
