LGTM with comments:
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-arm.cc#newcode809
src/arm/lithium-arm.cc:809: constant_value = constant->Integer32Value()
& 0x1f;
Use JSShiftAmountFromHConstant?
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-codegen-arm.cc#newcode1731
src/arm/lithium-codegen-arm.cc:1731: right = ToOperand(right_op);
Doesn't ToShiftedRightOperand take care of this case?
https://codereview.chromium.org/312173002/diff/1/src/arm/lithium-codegen-arm.cc#newcode1793
src/arm/lithium-codegen-arm.cc:1793: uint8_t shift_count =
static_cast<uint8_t>(value & 0x1F);
The original CL used JSShiftAmountFromLConstant here and in other
places.
https://codereview.chromium.org/312173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
