Revision: 21744
Author: [email protected]
Date: Tue Jun 10 12:49:04 2014 UTC
Log: Relax assertion in StoreBuffer::FindPointersToNewSpaceInMapsRegion
Since r21232, maps are now a non-power-of-two size and thus don't fit
evenly into a page. No test case, as it is somewhat difficult to get
this condition to trigger. It is possible with this case, however:
var result;
(function() {
for (var i = 0; i < 1e7; i++) {
result = (function*() { yield 1; })();
result.foo = 1;
}
})();
[email protected]
BUG=
Review URL: https://codereview.chromium.org/291913002
Patch from Andy Wingo <[email protected]>.
http://code.google.com/p/v8/source/detail?r=21744
Modified:
/branches/bleeding_edge/src/store-buffer.cc
=======================================
--- /branches/bleeding_edge/src/store-buffer.cc Thu Jun 5 12:14:47 2014 UTC
+++ /branches/bleeding_edge/src/store-buffer.cc Tue Jun 10 12:49:04 2014 UTC
@@ -450,7 +450,7 @@
Address map_aligned_end = MapEndAlign(end);
ASSERT(map_aligned_start == start);
- ASSERT(map_aligned_end == end);
+ ASSERT(map_aligned_start <= map_aligned_end && map_aligned_end <= end);
FindPointersToNewSpaceInMaps(map_aligned_start,
map_aligned_end,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
