lgtm! (with 2 last nits)
https://codereview.chromium.org/57123002/diff/1540001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/57123002/diff/1540001/src/hydrogen.cc#newcode1425
src/hydrogen.cc:1425: Add<HLoadNamedField>(map,
static_cast<HValue*>(NULL), access);
nit: 4-space indent.
https://codereview.chromium.org/57123002/diff/1540001/src/hydrogen.cc#newcode1546
src/hydrogen.cc:1546: STATIC_ASSERT(JS_GLOBAL_PROXY_TYPE ==
JS_BUILTINS_OBJECT_TYPE + 1);
This second ASSERT is now superfluous.
https://codereview.chromium.org/57123002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
