https://codereview.chromium.org/264333007/diff/150001/src/debug.cc
File src/debug.cc (left):
https://codereview.chromium.org/264333007/diff/150001/src/debug.cc#oldcode2705
src/debug.cc:2705: if (was_in_scope && (after_compile_flags &
SEND_WHEN_DEBUGGING) == 0) return;
Is it guaranteed that when this method is called from CompileToplevel,
we are not in the debug scope? If not, this will change behavior.
https://codereview.chromium.org/264333007/diff/150001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/264333007/diff/150001/src/parser.cc#newcode3863
src/parser.cc:3863: isolate()->Throw(*result, &location);
Won't Debug::OnException trigger as well? The call to
Debug::OnCompileError doesn't actually contain the syntax error
location, right? So you would need the following Debug::OnException to
get the actual syntax error location, right? A split API like that is
kind of weird.
https://codereview.chromium.org/264333007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
