Revision: 21779
Author: [email protected]
Date: Wed Jun 11 18:12:03 2014 UTC
Log: Drop globals.h include from platform.h
Also delete dead cpu-features-implied-by-platform code.
BUG=none
[email protected]
LOG=n
Review URL: https://codereview.chromium.org/326333002
http://code.google.com/p/v8/source/detail?r=21779
Modified:
/branches/bleeding_edge/src/arm/assembler-arm.cc
/branches/bleeding_edge/src/ia32/assembler-ia32.cc
/branches/bleeding_edge/src/mips/assembler-mips.cc
/branches/bleeding_edge/src/platform-posix.cc
/branches/bleeding_edge/src/platform-win32.cc
/branches/bleeding_edge/src/platform.h
/branches/bleeding_edge/src/x64/assembler-x64.cc
/branches/bleeding_edge/src/x87/assembler-x87.cc
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.cc Tue Jun 3 16:41:48
2014 UTC
+++ /branches/bleeding_edge/src/arm/assembler-arm.cc Wed Jun 11 18:12:03
2014 UTC
@@ -72,7 +72,6 @@
void CpuFeatures::ProbeImpl(bool cross_compile) {
- supported_ |= OS::CpuFeaturesImpliedByPlatform();
supported_ |= CpuFeaturesImpliedByCompiler();
cache_line_size_ = 64;
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.cc Tue Jun 3 08:12:43
2014 UTC
+++ /branches/bleeding_edge/src/ia32/assembler-ia32.cc Wed Jun 11 18:12:03
2014 UTC
@@ -52,7 +52,6 @@
CPU cpu;
CHECK(cpu.has_sse2()); // SSE2 support is mandatory.
CHECK(cpu.has_cmov()); // CMOV support is mandatory.
- supported_ |= OS::CpuFeaturesImpliedByPlatform();
// Only use statically determined features for cross compile (snapshot).
if (cross_compile) return;
=======================================
--- /branches/bleeding_edge/src/mips/assembler-mips.cc Tue Jun 10 09:24:00
2014 UTC
+++ /branches/bleeding_edge/src/mips/assembler-mips.cc Wed Jun 11 18:12:03
2014 UTC
@@ -87,7 +87,6 @@
void CpuFeatures::ProbeImpl(bool cross_compile) {
- supported_ |= OS::CpuFeaturesImpliedByPlatform();
supported_ |= CpuFeaturesImpliedByCompiler();
// Only use statically determined features for cross compile (snapshot).
=======================================
--- /branches/bleeding_edge/src/platform-posix.cc Thu Jun 5 12:14:47 2014
UTC
+++ /branches/bleeding_edge/src/platform-posix.cc Wed Jun 11 18:12:03 2014
UTC
@@ -56,11 +56,6 @@
static const pthread_t kNoThread = (pthread_t) 0;
-unsigned OS::CpuFeaturesImpliedByPlatform() {
- return 0; // Nothing special.
-}
-
-
int OS::NumberOfProcessorsOnline() {
return static_cast<int>(sysconf(_SC_NPROCESSORS_ONLN));
}
=======================================
--- /branches/bleeding_edge/src/platform-win32.cc Thu Jun 5 12:14:47 2014
UTC
+++ /branches/bleeding_edge/src/platform-win32.cc Wed Jun 11 18:12:03 2014
UTC
@@ -1158,11 +1158,6 @@
#endif // __MINGW32__
-unsigned OS::CpuFeaturesImpliedByPlatform() {
- return 0; // Windows runs on anything.
-}
-
-
int OS::NumberOfProcessorsOnline() {
SYSTEM_INFO info;
GetSystemInfo(&info);
=======================================
--- /branches/bleeding_edge/src/platform.h Thu Jun 5 12:14:47 2014 UTC
+++ /branches/bleeding_edge/src/platform.h Wed Jun 11 18:12:03 2014 UTC
@@ -23,9 +23,9 @@
#include <stdarg.h>
+#include "src/base/build_config.h"
#include "src/platform/mutex.h"
#include "src/platform/semaphore.h"
-#include "src/globals.h"
#include "src/vector.h"
#ifdef __sun
@@ -263,13 +263,6 @@
// using --never-compact) if accurate profiling is desired.
static void SignalCodeMovingGC();
- // The return value indicates the CPU features we are sure of because of
the
- // OS.
- // This is a little messy because the interpretation is subject to the
cross
- // of the CPU and the OS. The bits in the answer correspond to the bit
- // positions indicated by the members of the CpuFeature enum from
globals.h
- static unsigned CpuFeaturesImpliedByPlatform();
-
// Returns the number of processors online.
static int NumberOfProcessorsOnline();
=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64.cc Tue Jun 3 08:12:43
2014 UTC
+++ /branches/bleeding_edge/src/x64/assembler-x64.cc Wed Jun 11 18:12:03
2014 UTC
@@ -20,8 +20,6 @@
CHECK(cpu.has_sse2()); // SSE2 support is mandatory.
CHECK(cpu.has_cmov()); // CMOV support is mandatory.
- supported_ |= OS::CpuFeaturesImpliedByPlatform();
-
// Only use statically determined features for cross compile (snapshot).
if (cross_compile) return;
=======================================
--- /branches/bleeding_edge/src/x87/assembler-x87.cc Tue Jun 3 08:12:43
2014 UTC
+++ /branches/bleeding_edge/src/x87/assembler-x87.cc Wed Jun 11 18:12:03
2014 UTC
@@ -50,7 +50,6 @@
void CpuFeatures::ProbeImpl(bool cross_compile) {
CPU cpu;
- supported_ |= OS::CpuFeaturesImpliedByPlatform();
// Only use statically determined features for cross compile (snapshot).
if (cross_compile) return;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
