+dcarney Dan has graciously offered to take a look at all of these and fix them.
Danno ---------------------------------------------- *Daniel CliffordV8 Technical Lead and ManagerGoogle Germany GmbH* *Dienerstr. 12* *80331 München* ---------------------------------------------- Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores ---------------------------------------------- On Wed, Jun 11, 2014 at 4:09 AM, Hans Wennborg <[email protected]> wrote: > Hi all, > > Recent versions of Clang are starting to optimize based on certain > pointers being known to be non-null. > > For example, taking the address of a reference never results in null, > and the 'this' pointer can also never be null in a well-defined > context. > > This means that the following code: > > if (this == NULL) { > foo(); > } > > could be optimized away. > > They're adding warnings to catch these issues, and we'd like to clean > them up before rolling in the next Clang version in Chromium (see > crbug.com/381910). It's firing in the following places: > > src/api.cc:1196:24 > src/api.cc:1621:7 > src/api.cc:2915:24 > src/api.cc:2942:24 > src/api.cc:2974:24 > src/hydrogen-load-elimination.cc:28:9 > src/spaces.h:932:26 > src/spaces.h:934:9 > v8/src/spaces.h:938:9 > > Some of these seem tricky to fix. Is anyone interested in helping out? > > Thanks, > Hans > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
