Wohoo, thanks for reviewing!
I lifted the New(Null,Undefined,TheHole) one level up as you suggested and
removed NewSpecialLiteral.
I also clang-formatted some constructors in ast-value-factory.h which were
formatted weirdly before.
https://codereview.chromium.org/314603004/diff/140001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/314603004/diff/140001/src/ast-value-factory.h#newcode188
src/ast-value-factory.h:188: type_(t) {}
On 2014/06/12 12:20:28, rossberg wrote:
Perhaps ASSERT that t in {NULL, UNDEFINED, HOLE}.
Done.
https://codereview.chromium.org/314603004/diff/140001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/314603004/diff/140001/src/parser.cc#newcode692
src/parser.cc:692: return factory->NewSpecialLiteral(
On 2014/06/12 12:20:28, rossberg wrote:
Nit: just for symmetry, I would wrap this up into a NewNullLiteral.
Done.
https://codereview.chromium.org/314603004/diff/140001/src/parser.cc#newcode734
src/parser.cc:734: return factory->NewSpecialLiteral(
On 2014/06/12 12:20:28, rossberg wrote:
...and similarly here.
Done.
https://codereview.chromium.org/314603004/diff/140001/src/parser.cc#newcode3673
src/parser.cc:3673: Expression* undefined =
factory()->NewSpecialLiteral(
On 2014/06/12 12:20:28, rossberg wrote:
...and here.
Done.
https://codereview.chromium.org/314603004/diff/140001/src/parser.cc#newcode3769
src/parser.cc:3769: return
factory()->NewSpecialLiteral(ast_value_factory_->NewUndefined(),
On 2014/06/12 12:20:28, rossberg wrote:
...and here.
Done.
https://codereview.chromium.org/314603004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
