[+Ben]
Ben, wdyt about the HObjectAccess comment?
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h#newcode6785
src/hydrogen-instructions.h:6785: return true;
Could you please port this to other architectures and get rid of this
function?
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h#newcode6791
src/hydrogen-instructions.h:6791: return !(access.IsExternalMemory() ||
This predicate should be part of HObjectAccess (if Ben doesn't
disagree).
https://codereview.chromium.org/324093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
