On 2014/06/12 12:36:40, rossberg wrote:
LGTM. You might want to add a simple test checking that generators
actually
have
a @@iterator property now.
Will do so in a followup.
> PTAL. The change to the AST is kinda nasty but seemed to be the
smallest
change
> I could make to do the right thing (namely, shortcutting the loop if the
> iterable is null or undefined, and otherwise binding the iterator to
> iterable[@@iterator]()).
Oh dear, I hadn't even noticed that special case. Seems wrong, especially
for
undefined, where it will mostly just mask bugs.
I agree but I think my (bad) language design instincts aren't the same as
Allen's :)
https://codereview.chromium.org/332663004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
