On 2014/06/12 at 07:25:16, marja wrote:
Code LGTM. Looks like a reasonable thing to do. There might be some surprising
breakage though, like, some scripts might have the wrong get/set parameter count
inside lazy functions which were never executed. But I think this is worth
trying out nevertheless.

Thanks. Can you land this for me?

The following throws an error as expected:

```js
var s = 'return /*' + Array(1e6).join(' ') + '*/ {get x(error) {}};';
Function(s);
```

Is this a valid way to test the preparser? (I got the idea from Andy's CL at
https://codereview.chromium.org/332443002)

If not, then I need to investigate more time on how we do early syntax errors
for strict functions that have duplicate property names in object literals.

https://codereview.chromium.org/329413002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to