lgtm with suggestion
https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/335653002/diff/1/src/bootstrapper.cc#newcode271
src/bootstrapper.cc:271: enum ForBoundFunctionMode {
I'd rather name this
enum FunctionMapMode {
REGULAR_FUNCTION_MAP,
BOUND_FUNCTION_MAP
}
And perhaps you could even merge it with the above
PrototypePropertyMode, since BOUND_FUNCTION always implies
DONT_ADD_PROTOTYPE:
enum FunctionMode {
// With prototype.
FUNCTION_WITH_WRITEABLE_PROTOTYPE,
FUNCTION_WITH_READONLY_PROTOTYPE,
// Without prototype.
FUNCTION_WITHOUT_PROTOTYPE,
BOUND_FUNCTION
}
https://codereview.chromium.org/335653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
