lgtm with comment
https://codereview.chromium.org/335553004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/335553004/diff/1/src/objects.cc#newcode4861
src/objects.cc:4861: if (object->map() ==
heap->sloppy_arguments_elements_map()) {
Are you sure this can ever happen? We never handled that case before.
It's probably worthwhile to ask the O.o guys why they decided to add it.
Might just be defensive programming... I'd prefer to not have such code
clutter the code-base confusing us, if it's not necessary.
https://codereview.chromium.org/335553004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
