On 2014/06/13 10:13:23, Rodolph Perfetta wrote:
https://codereview.chromium.org/331803003/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/331803003/diff/1/src/arm/assembler-arm.cc#newcode106
src/arm/assembler-arm.cc:106: if (FLAG_enable_mls && cpu.has_thumbee())
supported_ |= 1u << MLS;
DBC: You should check for ARMv7 not ThumbEE.
ThumbEE is deprecated, the newer cores (A53, A57) don't have it.
This should be renamed to Thumb2. ThumbEE was the wrong name anyway.
But testing for T2 is correct, since mls was introduced with ARMv6T2.
https://codereview.chromium.org/331803003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
