lgtm
https://codereview.chromium.org/314603004/diff/220001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/314603004/diff/220001/src/ast-value-factory.h#newcode159
src/ast-value-factory.h:159: SYMBOL
Nitty nit: move up next to string
https://codereview.chromium.org/314603004/diff/240001/src/ast-value-factory.cc
File src/ast-value-factory.cc (right):
https://codereview.chromium.org/314603004/diff/240001/src/ast-value-factory.cc#newcode199
src/ast-value-factory.cc:199: value_ = Object::GetProperty(
Yeah, I suppose that's fine. I had hoped to keep those variables an
implementation detail of the symbol module (and an unfortunate artefact
that they are actually exposed). But re-calling InternalSymbol instead
probably isn't any nicer.
https://codereview.chromium.org/314603004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
