Reviewers: Benedikt Meurer,
Description:
Move random seed flag handling out of RNG
BUG=none
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/333053002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -26 lines):
M src/isolate-inl.h
M src/utils/random-number-generator.cc
M test/cctest/test-random-number-generator.cc
Index: src/isolate-inl.h
diff --git a/src/isolate-inl.h b/src/isolate-inl.h
index
c33e61d41777618478bb66cf71ed83913f2d3e4f..12a861f2b8961653c63566bef388735739c2db83
100644
--- a/src/isolate-inl.h
+++ b/src/isolate-inl.h
@@ -32,7 +32,11 @@ bool Isolate::DebuggerHasBreakPoints() {
RandomNumberGenerator* Isolate::random_number_generator() {
if (random_number_generator_ == NULL) {
- random_number_generator_ = new RandomNumberGenerator;
+ if (FLAG_random_seed != 0) {
+ random_number_generator_ = new
RandomNumberGenerator(FLAG_random_seed);
+ } else {
+ random_number_generator_ = new RandomNumberGenerator();
+ }
}
return random_number_generator_;
}
Index: src/utils/random-number-generator.cc
diff --git a/src/utils/random-number-generator.cc
b/src/utils/random-number-generator.cc
index
cf71c6aa66497ad10b4ae7b582c83d6b777c2320..7d851d8a2e60dad0c3401216f906316e07c28197
100644
--- a/src/utils/random-number-generator.cc
+++ b/src/utils/random-number-generator.cc
@@ -7,7 +7,6 @@
#include <stdio.h>
#include <stdlib.h>
-#include "src/flags.h"
#include "src/platform/mutex.h"
#include "src/platform/time.h"
#include "src/utils.h"
@@ -27,12 +26,6 @@ void
RandomNumberGenerator::SetEntropySource(EntropySource source) {
RandomNumberGenerator::RandomNumberGenerator() {
- // Check --random-seed flag first.
- if (FLAG_random_seed != 0) {
- SetSeed(FLAG_random_seed);
- return;
- }
-
// Check if embedder supplied an entropy source.
{ LockGuard<Mutex> lock_guard(entropy_mutex.Pointer());
if (entropy_source != NULL) {
Index: test/cctest/test-random-number-generator.cc
diff --git a/test/cctest/test-random-number-generator.cc
b/test/cctest/test-random-number-generator.cc
index
b8cf860d19edebdc31050be9d7fce7fd2225a4e3..dd66c7e64a1621f44fa795e5ded7f8edcdaf7d79
100644
--- a/test/cctest/test-random-number-generator.cc
+++ b/test/cctest/test-random-number-generator.cc
@@ -72,21 +72,3 @@ TEST(NextDoubleRange) {
}
}
}
-
-
-TEST(RandomSeedFlagIsUsed) {
- for (unsigned n = 0; n < ARRAY_SIZE(kRandomSeeds); ++n) {
- FLAG_random_seed = kRandomSeeds[n];
- RandomNumberGenerator rng1;
- RandomNumberGenerator rng2(kRandomSeeds[n]);
- for (int k = 1; k <= kMaxRuns; ++k) {
- int64_t i1, i2;
- rng1.NextBytes(&i1, sizeof(i1));
- rng2.NextBytes(&i2, sizeof(i2));
- CHECK_EQ(i2, i1);
- CHECK_EQ(rng2.NextInt(), rng1.NextInt());
- CHECK_EQ(rng2.NextInt(k), rng1.NextInt(k));
- CHECK_EQ(rng2.NextDouble(), rng1.NextDouble());
- }
- }
-}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
