LGTM with comment.
https://codereview.chromium.org/333053002/diff/40001/test/cctest/test-random-number-generator.cc
File test/cctest/test-random-number-generator.cc (left):
https://codereview.chromium.org/333053002/diff/40001/test/cctest/test-random-number-generator.cc#oldcode77
test/cctest/test-random-number-generator.cc:77:
TEST(RandomSeedFlagIsUsed) {
Please move this test in test-isolate.cc to test that the new
random_number_generator() function actually uses the FLAG_random_seed.
https://codereview.chromium.org/333053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
