Revision: 21850
Author: [email protected]
Date: Mon Jun 16 08:41:29 2014 UTC
Log: Fix representation of Phis for
mutable-heapnumber-in-object-literal properties
BUG=v8:3392
LOG=y
[email protected]
Review URL: https://codereview.chromium.org/328343004
http://code.google.com/p/v8/source/detail?r=21850
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-3392.js
Modified:
/branches/bleeding_edge/src/hydrogen.cc
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-3392.js Mon Jun 16
08:41:29 2014 UTC
@@ -0,0 +1,18 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function foo() {
+ var a = {b: -1.5};
+ for (var i = 0; i < 1; i++) {
+ a.b = 1;
+ }
+ assertTrue(0 <= a.b);
+}
+
+foo();
+foo();
+%OptimizeFunctionOnNextCall(foo);
+foo();
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Fri Jun 13 12:52:23 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc Mon Jun 16 08:41:29 2014 UTC
@@ -11010,7 +11010,7 @@
// 1) it's a child object of another object with a valid
allocation site
// 2) we can just use the mode of the parent object for pretenuring
HInstruction* double_box =
- Add<HAllocate>(heap_number_constant, HType::HeapNumber(),
+ Add<HAllocate>(heap_number_constant, HType::HeapObject(),
pretenure_flag, HEAP_NUMBER_TYPE);
AddStoreMapConstant(double_box,
isolate()->factory()->heap_number_map());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
