On 2014/06/16 at 07:37:57, marja wrote:
Hmm, I ran make quickcheck for this CL, but it fails...

The failing test is mozilla/data/js1_5/extensions/regress-367501-01.js. It
does this:

   try
   {
     expect = 'undefined';
     var a = { set x() {} };
     actual = a.x + '';
   }
   catch(ex)
   {
   }

The corresponding bug is https://bugzila.mozilla.org/show_bug.cgi?id=367501
which, afaics, is about doing the wrong thing when code like this is ran (like,
writing to / reading from a wrong location in memory).

I guess it's safe to disable this test in V8?

SpiderMonkey also throws a syntax error for this and no code is run.

I think we should just remove these tests
(mozilla/data/js1_5/extensions/regress-367501-*.js)

https://codereview.chromium.org/329413002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to