lgtm with nits
https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h
File src/base/safe_conversions_impl.h (right):
https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h#newcode8
src/base/safe_conversions_impl.h:8: #ifndef
BASE_SAFE_CONVERSIONS_IMPL_H_
please use V8_BASE_SAFE_CONVERSIONS_IMPL_H_
https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h#newcode16
src/base/safe_conversions_impl.h:16: namespace internal {
please use namespace v8::base in the base library
https://codereview.chromium.org/336183003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
