On 2014/06/16 12:40:53, yurys wrote:
lgtm
https://codereview.chromium.org/265593002/diff/180001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/265593002/diff/180001/src/api.cc#newcode1953
src/api.cc:1953: isolate));
style: wrong indentation.
Fixed.
https://codereview.chromium.org/265593002/diff/180001/src/api.cc#newcode1954
src/api.cc:1954: i::Handle<i::Script>
script(i::Script::cast(scriptValue->value()));
Why not i::Script::cast(message->script()) without intermediate cast to
JSValue?
Message object contains ScriptWrapper instead Script:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/objects.cc&l=10346.
ScriptWrapper is JSValue.
https://codereview.chromium.org/265593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
