Revision: 21866
Author:   [email protected]
Date:     Tue Jun 17 06:48:55 2014 UTC
Log:      Version 3.27.32 (based on bleeding_edge revision r21865)

Performance and stability improvements on all platforms.
http://code.google.com/p/v8/source/detail?r=21866

Added:
 /trunk/test/mjsunit/regress/regress-385054.js
Modified:
 /trunk/ChangeLog
 /trunk/src/heap.cc
 /trunk/src/heap.h
 /trunk/src/hydrogen-bce.cc
 /trunk/src/hydrogen-gvn.cc
 /trunk/src/hydrogen-instructions.h
 /trunk/src/version.cc

=======================================
--- /dev/null
+++ /trunk/test/mjsunit/regress/regress-385054.js Tue Jun 17 06:48:55 2014 UTC
@@ -0,0 +1,16 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function f(x) {
+  var a = [1, 2];
+  a[x];
+  return a[0 - x];
+}
+
+f(0);
+f(0);
+%OptimizeFunctionOnNextCall(f);
+assertEquals(undefined, f(1));
=======================================
--- /trunk/ChangeLog    Mon Jun 16 11:36:14 2014 UTC
+++ /trunk/ChangeLog    Tue Jun 17 06:48:55 2014 UTC
@@ -1,3 +1,8 @@
+2014-06-17: Version 3.27.32
+
+        Performance and stability improvements on all platforms.
+
+
 2014-06-16: Version 3.27.31

         Version fix.
=======================================
--- /trunk/src/heap.cc  Mon Jun 16 11:20:10 2014 UTC
+++ /trunk/src/heap.cc  Tue Jun 17 06:48:55 2014 UTC
@@ -60,6 +60,7 @@
 // Will be 4 * reserved_semispace_size_ to ensure that young
 // generation can be aligned to its size.
       maximum_committed_(0),
+      old_space_growing_factor_(4),
       survived_since_last_expansion_(0),
       sweep_generation_(0),
       always_allocate_scope_depth_(0),
@@ -5024,6 +5025,12 @@
           AllocationMemento::kSize));

   code_range_size_ = code_range_size * MB;
+
+ // We set the old generation growing factor to 2 to grow the heap slower on
+  // memory-constrained devices.
+  if (max_old_generation_size_ <= kMaxOldSpaceSizeMediumMemoryDevice) {
+    old_space_growing_factor_ = 2;
+  }

   configured_ = true;
   return true;
=======================================
--- /trunk/src/heap.h   Mon Jun 16 11:20:10 2014 UTC
+++ /trunk/src/heap.h   Tue Jun 17 06:48:55 2014 UTC
@@ -1074,23 +1074,9 @@
       700 * kPointerMultiplier;

   intptr_t OldGenerationAllocationLimit(intptr_t old_gen_size) {
-    intptr_t limit;
-    if (FLAG_stress_compaction) {
-      limit = old_gen_size + old_gen_size / 10;
-    } else if (old_gen_size < max_old_generation_size_ / 8) {
-      if (max_old_generation_size_ <= kMaxOldSpaceSizeMediumMemoryDevice) {
-        limit = old_gen_size * 2;
-      } else {
-        limit = old_gen_size * 4;
-      }
-    } else if (old_gen_size < max_old_generation_size_ / 4) {
-      limit = static_cast<intptr_t>(old_gen_size * 1.5);
-    } else if (old_gen_size < max_old_generation_size_ / 2) {
-      limit = static_cast<intptr_t>(old_gen_size * 1.2);
-    } else {
-      limit = static_cast<intptr_t>(old_gen_size * 1.1);
-    }
-
+    intptr_t limit = FLAG_stress_compaction
+        ? old_gen_size + old_gen_size / 10
+        : old_gen_size * old_space_growing_factor_;
     limit = Max(limit, kMinimumOldGenerationAllocationLimit);
     limit += new_space_.Capacity();
intptr_t halfway_to_the_max = (old_gen_size + max_old_generation_size_) / 2;
@@ -1515,6 +1501,11 @@
   intptr_t max_executable_size_;
   intptr_t maximum_committed_;

+  // The old space growing factor is used in the old space heap growing
+  // strategy. The new old space size is the current old space size times
+  // old_space_growing_factor_.
+  int old_space_growing_factor_;
+
   // For keeping track of how much data has survived
   // scavenge since last new space expansion.
   int survived_since_last_expansion_;
=======================================
--- /trunk/src/hydrogen-bce.cc  Thu Jun  5 00:04:53 2014 UTC
+++ /trunk/src/hydrogen-bce.cc  Tue Jun 17 06:48:55 2014 UTC
@@ -47,10 +47,7 @@
     } else if (check->index()->IsSub()) {
       HSub* index = HSub::cast(check->index());
       is_sub = true;
-      if (index->left()->IsConstant()) {
-        constant = HConstant::cast(index->left());
-        index_base = index->right();
-      } else if (index->right()->IsConstant()) {
+      if (index->right()->IsConstant()) {
         constant = HConstant::cast(index->right());
         index_base = index->left();
       }
=======================================
--- /trunk/src/hydrogen-gvn.cc  Mon Jun 16 00:04:47 2014 UTC
+++ /trunk/src/hydrogen-gvn.cc  Tue Jun 17 06:48:55 2014 UTC
@@ -466,7 +466,7 @@
 bool SideEffectsTracker::ComputeInobjectField(HObjectAccess access,
                                               int* index) {
   for (int i = 0; i < num_inobject_fields_; ++i) {
-    if (access.SameField(inobject_fields_[i])) {
+    if (access.Equals(inobject_fields_[i])) {
       *index = i;
       return true;
     }
=======================================
--- /trunk/src/hydrogen-instructions.h  Mon Jun 16 00:04:47 2014 UTC
+++ /trunk/src/hydrogen-instructions.h  Tue Jun 17 06:48:55 2014 UTC
@@ -6202,14 +6202,7 @@
   void PrintTo(StringStream* stream) const;

   inline bool Equals(HObjectAccess that) const {
-    return value_ == that.value_;
-  }
-
- // Returns true if |this| access refers to the same field as |that|, which
-  // means that both have same |offset| and |portion| values.
-  inline bool SameField(HObjectAccess that) const {
-    uint32_t mask = PortionField::kMask | OffsetField::kMask;
-    return (value_ & mask) == (that.value_ & mask);
+    return value_ == that.value_;  // portion and offset must match
   }

  protected:
=======================================
--- /trunk/src/version.cc       Mon Jun 16 11:36:14 2014 UTC
+++ /trunk/src/version.cc       Tue Jun 17 06:48:55 2014 UTC
@@ -34,7 +34,7 @@
 // system so their names cannot be changed without changing the scripts.
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     27
-#define BUILD_NUMBER      31
+#define BUILD_NUMBER      32
 #define PATCH_LEVEL       0
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to