LGTM
https://codereview.chromium.org/325553002/diff/80001/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/325553002/diff/80001/src/heap-inl.h#newcode306
src/heap-inl.h:306: (static_cast<uint32_t>(allocation_space) <<
kPageSizeBits);
Why do you need the or (static_cast<uint32_t>(allocation_space) <<
kPageSizeBits);
https://codereview.chromium.org/325553002/diff/80001/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/325553002/diff/80001/src/spaces-inl.h#newcode258
src/spaces-inl.h:258: !heap()->linear_allocation() ||
I do not think the assert is correct.
I think linear_allocation will always be true.
https://codereview.chromium.org/325553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
