LGTM if benchmarks support it.
https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode1978
src/mark-compact.cc:1978: int
MarkCompactCollector::DiscoverAndPromoteBlackObjectsOnPage(
nit: IMHO the name of this function no longer applies, should be maybe
rename it to "DiscoverAndMigrateBlackObjectsOnPage"?
https://codereview.chromium.org/345523002/diff/1/src/mark-compact.cc#newcode2013
src/mark-compact.cc:2013: if (heap_->ShouldBePromoted(object->address(),
size) &&
nit: s/heap_/heap()/
https://codereview.chromium.org/345523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
