On 2014/06/18 12:26:43, wingo wrote:
On 2014/06/18 12:07:39, Yang wrote:
> https://codereview.chromium.org/345533002/diff/1/src/isolate.cc
> File src/isolate.cc (right):
>
>
https://codereview.chromium.org/345533002/diff/1/src/isolate.cc#newcode796
> src/isolate.cc:796: int limit;
> Can we simply use FastD2IChecked here? Also, please note that in V8 we
generally
> use brackets around if-else blocks.
Sure, although it's not clear to me what FastD2IChecked does with a NaN.
Will
figure that out and fix the style.
It should convert a NaN to MIN_INT, since every comparison with a NaN fails.
https://codereview.chromium.org/345533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
