lgtm with nits:
https://codereview.chromium.org/347503003/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/347503003/diff/1/src/factory.cc#newcode277
src/factory.cc:277: NewRawOneByteString(string.length(), pretenure),
string.length() -> length
https://codereview.chromium.org/347503003/diff/1/src/factory.cc#newcode286
src/factory.cc:286: NewRawTwoByteString(string.length(), pretenure),
string.length() -> length
https://codereview.chromium.org/347503003/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/347503003/diff/1/src/heap-inl.h#newcode541
src/heap-inl.h:541: __object__ = __allocation__.ToObjectChecked();
\
While we are here: what about
if (__allocation__.To(&__object__)) {
instead of two lines above?
https://codereview.chromium.org/347503003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
