Reviewers: danno, Jakob,
Message:
Hi Danno,
PTAL, here is the dehoist overflow CL now with the use of the safe numerics
library for overflow checking. It is fitting that it was kicked out of the
tree
last week because of a buggy "hand crafted" overflow checker. :)
Note - I kept the base_offset in HLoad/StoreKeyed as uint32_t because there
is
safe addition now and it confuses me to store a "signed" integer in the
bitfield
of HLoadKeyed.
Hi Jakob, please see the wrappers I added in utils.h for the use of safe
numerics, and a small test. The library itself is exhaustively tested in
chromium.
Description:
Re-land "Clusterfuzz identified overflow check needed in dehoisting."
BUG=380092
LOG=N
Please review this at https://codereview.chromium.org/335063005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+94, -17 lines):
M src/hydrogen-dehoist.cc
M src/hydrogen-instructions.h
M src/utils.h
M test/cctest/test-utils.cc
A test/mjsunit/regress/regress-380092.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
