https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc
File src/arm/debug-arm.cc (right):
https://codereview.chromium.org/344573004/diff/1/src/arm/debug-arm.cc#newcode152
src/arm/debug-arm.cc:152:
On 2014/06/18 15:03:55, Yang wrote:
Are you sure this is correct? A brief comparison to the ia32 and x64
port shows
that this part is quite different. Can you explain where the frame is
going to
be restored?
FrameAndConstantPoolScope destructor is called here at the end of the
block. It makes a call to masm_->LeaveFrame(), see here:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/arm/macro-assembler-arm.h&q=FrameAndConstantPoolScope&sq=package:chromium&type=cs&l=1549
which in turn restores sp from fp:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/arm/macro-assembler-arm.cc&sq=package:chromium&type=cs&l=1064
https://codereview.chromium.org/344573004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
