Code looks fine (especially so since it closely mirrors the spec), one test
suggestion.
https://codereview.chromium.org/345613003/diff/20001/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
https://codereview.chromium.org/345613003/diff/20001/test/mjsunit/harmony/collections.js#newcode1036
test/mjsunit/harmony/collections.js:1036: (function
TestSetConstructorAddNotCallable() {
Another more complicated version of this test would be nice to have,
which demonstrates that you cache the adder method at the start. E.g.,
you could wrap add in another method that replaces itself with 42 on
Set.prototype the first time it's called. And a similar test for Map.
https://codereview.chromium.org/345613003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
