Reviewers: Yang,
Message:
As noted in the patch description, I'm not sure how easy this is to test
inside
v8. I only see one mention of %GetFrameDetails under test...any suggestions
for
testing would be appreciated.
Description:
Avoid crashing when Runtime_GetFrameDetails is called on a RunMicrotasks
stack
frame
See attached bug for the crash reproduction: it involves three different web
platform features and having the inspector open. Not clear how feasible this
is to turn into a v8 test case.
BUG=385349
Please review this at https://codereview.chromium.org/346933002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
b97af64f838b6c2386c4b90b914bf82f0b0a2fdf..69a30535de33a89cf2dc5aa7262c0f50163be8f5
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -11402,7 +11402,8 @@ RUNTIME_FUNCTION(Runtime_GetFrameDetails) {
// bit 1: optimized frame.
// bit 2: inlined in optimized frame
int flags = 0;
- if (*save->context() == *isolate->debug()->debug_context()) {
+ if (!save->context().is_null() &&
+ *save->context() == *isolate->debug()->debug_context()) {
flags |= 1 << 0;
}
if (is_optimized) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
