thx for comments! Submitting...
https://codereview.chromium.org/335063005/diff/80001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/335063005/diff/80001/src/hydrogen-instructions.cc#newcode3495
src/hydrogen-instructions.cc:3495: addition_result = addition_result +
increase_by_value;
On 2014/06/20 08:24:50, Jakob wrote:
nit: consider using += for conciseness.
Done.
https://codereview.chromium.org/335063005/diff/80001/src/hydrogen-instructions.cc#newcode3497
src/hydrogen-instructions.cc:3497:
!BaseOffsetField::is_valid(base_offset + increase_by_value)) {
On 2014/06/20 08:24:50, Jakob wrote:
I'd split this check in two to make it clearer what's going on:
addition_result += increase_by_value;
if (!addition_result.IsValid()) return false;
base_offset = addition_result.ValueOrDie();
if (!BaseOffsetField::is_valid(base_offset)) return false;
bit_field_ = ...update(..., base_offset);
Good idea, thx, I like it better too.
https://codereview.chromium.org/335063005/diff/80001/src/hydrogen-instructions.cc#newcode4090
src/hydrogen-instructions.cc:4090: addition_result = addition_result +
increase_by_value;
On 2014/06/20 08:24:50, Jakob wrote:
nit: +=
Done.
https://codereview.chromium.org/335063005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
