Revision: 21921
Author: [email protected]
Date: Mon Jun 23 09:09:36 2014 UTC
Log: Simplify Object::GetElementWithReceiver
Don't inline GetPrototype() to avoid code duplication
BUG=none
[email protected]
LOG=n
Review URL: https://codereview.chromium.org/331313010
http://code.google.com/p/v8/source/detail?r=21921
Modified:
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/objects.cc Mon Jun 23 09:02:16 2014 UTC
+++ /branches/bleeding_edge/src/objects.cc Mon Jun 23 09:09:36 2014 UTC
@@ -809,26 +809,15 @@
!holder->IsNull();
holder = Handle<Object>(holder->GetPrototype(isolate), isolate)) {
if (!holder->IsJSObject()) {
- Context* native_context = isolate->context()->native_context();
- if (holder->IsNumber()) {
- holder = Handle<Object>(
- native_context->number_function()->instance_prototype(),
isolate);
- } else if (holder->IsString()) {
- holder = Handle<Object>(
- native_context->string_function()->instance_prototype(),
isolate);
- } else if (holder->IsSymbol()) {
- holder = Handle<Object>(
- native_context->symbol_function()->instance_prototype(),
isolate);
- } else if (holder->IsBoolean()) {
- holder = Handle<Object>(
- native_context->boolean_function()->instance_prototype(),
isolate);
- } else if (holder->IsJSProxy()) {
+ if (holder->IsJSProxy()) {
return JSProxy::GetElementWithHandler(
Handle<JSProxy>::cast(holder), receiver, index);
+ } else if (holder->IsUndefined()) {
+ // Undefined has no indexed properties.
+ return isolate->factory()->undefined_value();
} else {
- // Undefined and null have no indexed properties.
- ASSERT(holder->IsUndefined() || holder->IsNull());
- return isolate->factory()->undefined_value();
+ holder = Handle<Object>(holder->GetPrototype(isolate), isolate);
+ ASSERT(holder->IsJSObject());
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
