On 2014/06/23 11:52:29, vincent.belliard.arm wrote:
https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/349243002/diff/1/src/arm/lithium-codegen-arm.cc#newcode360
src/arm/lithium-codegen-arm.cc:360: __ add(scratch0(), scratch0(),
Both versions generate the same number of instructions. I left in the loop
because that what was done before for ARM (and I think it's a little bit
easier
to read).
Do you want me to put it out of the loop?
I just asked to make sure I didn't miss anything. Both versions lgtm. For
the
sake of consistency, it would be good to choose one version use it for both
architectures.
https://codereview.chromium.org/349243002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
