LGTM with comments.
https://codereview.chromium.org/346223007/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/346223007/diff/1/src/globals.h#newcode149
src/globals.h:149: const int kIntSizeLog2 = 3;
are you sure about this? I can haz STATIC_ASSERT(kIntSize == (1 <<
kIntSizeLog2))?
https://codereview.chromium.org/346223007/diff/1/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):
https://codereview.chromium.org/346223007/diff/1/src/runtime-profiler.cc#newcode124
src/runtime-profiler.cc:124:
nit: don't need this empty line (why did it move anyway?).
https://codereview.chromium.org/346223007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
