On 2014/01/16 12:58:39, Hannes Payer wrote:
Looking good, let's do another performance run.
LGTM
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen-instructions.h#newcode5463
src/hydrogen-instructions.h:5463: void set_size_upper_bound(HConstant*
value)
{
size_upper_bound_ = value; }
I guess set_size_upper_bound should only be called once for an
instruction.
Can
we assert that?
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen.cc#newcode2737
src/hydrogen.cc:2737: HConstant* elms_size_upper_bound =
capacity->IsInteger32Constant()
please use a full name elms -> elements
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen.cc#newcode2766
src/hydrogen.cc:2766: HValue* elms_size =
builder()->BuildCalculateElementsSize(kind_, capacity);
elms -> elements
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/61463005/diff/610001/src/hydrogen.h#newcode1693
src/hydrogen.h:1693: // Array must have been allocated with enough room
for
Can you keep array lower case since it refers to the variable below
Remake of this CL landed as https://codereview.chromium.org/304153009/
https://codereview.chromium.org/61463005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
