Reviewers: ulan, Benedikt Meurer,

Message:
I don't have a cross-compilation environment working for V8 with Clang, but this
works in isolation. I'm using Clang 3.5-1ubuntu1.

Description:
ARM: Fix inline assembly (r21949) for Clang.

Add a 'c' predicate to the immediate syscall number. This tells the
compiler to omit the leading '#' that immediates usually have in ARM.
The GNU assembler tolerates "ldr r7, =#1234" but Clang does not.

BUG=

Please review this at https://codereview.chromium.org/356463004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+1, -1 lines):
  M src/arm/cpu-arm.cc


Index: src/arm/cpu-arm.cc
diff --git a/src/arm/cpu-arm.cc b/src/arm/cpu-arm.cc
index 78ab5f7686e97373329c621c2b43b3c90e4fdc10..6412366f422c1b316561c5185e7f67f494dbe947 100644
--- a/src/arm/cpu-arm.cc
+++ b/src/arm/cpu-arm.cc
@@ -52,7 +52,7 @@ void CPU::FlushICache(void* start, size_t size) {
                                   // r0 = beg
                                   // r1 = end
                                   // r2 = flags (0)
-    "  ldr r7, =%[scno]\n"        // r7 = syscall number
+    "  ldr r7, =%c[scno]\n"       // r7 = syscall number
     "  svc 0\n"

     "  pop {r7}\n"


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to