LGTM if comments are addressed.
https://codereview.chromium.org/346413004/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/arm/code-stubs-arm.cc#newcode68
src/arm/code-stubs-arm.cc:68:
Runtime::kCreateArrayLiteralStubBailout)->entry;
nit: Does this fit into one line now?
https://codereview.chromium.org/346413004/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/arm64/code-stubs-arm64.cc#newcode74
src/arm64/code-stubs-arm64.cc:74: Runtime::FunctionForId(
nit: Likewise.
https://codereview.chromium.org/346413004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/runtime.cc#newcode15083
src/runtime.cc:15083: #undef FH
nit: Please also drop the "#undef FH" here.
https://codereview.chromium.org/346413004/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/serialize.cc#newcode459
src/serialize.cc:459: Add(ExternalReference(
nit: This should also fit into line again. Clang-format, where are you
in our moment of despair? :)
https://codereview.chromium.org/346413004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
