Revision: 21971
Author: [email protected]
Date: Tue Jun 24 13:58:56 2014 UTC
Log: Revert assertion change from r21933 in Isolate::RunMicrotasks().
[email protected]
Review URL: https://codereview.chromium.org/357453002
http://code.google.com/p/v8/source/detail?r=21971
Modified:
/branches/bleeding_edge/src/isolate.cc
=======================================
--- /branches/bleeding_edge/src/isolate.cc Mon Jun 23 11:47:20 2014 UTC
+++ /branches/bleeding_edge/src/isolate.cc Tue Jun 24 13:58:56 2014 UTC
@@ -2292,10 +2292,12 @@
void Isolate::RunMicrotasks() {
- // In some mjsunit tests %RunMicrotasks is called explicitly, violating
- // this assertion. Therefore we also check for --allow-natives-syntax.
- ASSERT(FLAG_allow_natives_syntax ||
- handle_scope_implementer()->CallDepthIsZero());
+ // %RunMicrotasks may be called in mjsunit tests, which violates
+ // this assertion, hence the check for --allow-natives-syntax.
+ // TODO(adamk): However, this also fails some layout tests.
+ //
+ // ASSERT(FLAG_allow_natives_syntax ||
+ // handle_scope_implementer()->CallDepthIsZero());
// Increase call depth to prevent recursive callbacks.
v8::Isolate::SuppressMicrotaskExecutionScope suppress(
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
