https://codereview.chromium.org/357443003/diff/1/src/sampler.h
File src/sampler.h (right):
https://codereview.chromium.org/357443003/diff/1/src/sampler.h#newcode51
src/sampler.h:51: unsigned frames_count : kMaxFramesCountLog2; //
Number of captured frames.
On 2014/06/24 13:54:37, Jakob wrote:
I'm not sure this will work. IIRC we've had an issue before where MSVS
insisted
on sign-extending a packed value when reading it back out, but I'm not
sure if
the circumstances were identical. If this fails on Windows (can you
test locally
before landing?), this would be something to take a closer look at.
MSVC is noisy about implicit signed/unsigned conversions. But I seem to
have all of them fixed. I've run the try jobs.
Alternatively, I can add an extra bit here and keep it signed int if you
like.
https://codereview.chromium.org/357443003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
