Reviewers: Michael Starzinger, Jakob,
Message:
Please take another look, specifically I made a bunch of changes so that
natives
fuzzing works again. Jakob, perhaps you want to take a look?
https://codereview.chromium.org/346413004/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/arm/code-stubs-arm.cc#newcode68
src/arm/code-stubs-arm.cc:68:
Runtime::kCreateArrayLiteralStubBailout)->entry;
On 2014/06/24 13:06:05, Michael Starzinger wrote:
nit: Does this fit into one line now?
Done.
https://codereview.chromium.org/346413004/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/arm64/code-stubs-arm64.cc#newcode74
src/arm64/code-stubs-arm64.cc:74: Runtime::FunctionForId(
On 2014/06/24 13:06:05, Michael Starzinger wrote:
nit: Likewise.
Done.
https://codereview.chromium.org/346413004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/runtime.cc#newcode15083
src/runtime.cc:15083: #undef FH
On 2014/06/24 13:06:05, Michael Starzinger wrote:
nit: Please also drop the "#undef FH" here.
Done.
https://codereview.chromium.org/346413004/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/346413004/diff/1/src/serialize.cc#newcode459
src/serialize.cc:459: Add(ExternalReference(
On 2014/06/24 13:06:05, Michael Starzinger wrote:
nit: This should also fit into line again. Clang-format, where are you
in our
moment of despair? :)
Done.
Description:
Remove distinction between hidden and normal runtime functions
Please review this at https://codereview.chromium.org/346413004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+764, -643 lines):
M src/arm/builtins-arm.cc
M src/arm/code-stubs-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm/macro-assembler-arm.cc
M src/arm64/builtins-arm64.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.cc
M src/arm64/macro-assembler-arm64.cc
M src/builtins.cc
M src/full-codegen.cc
M src/hydrogen.cc
M src/hydrogen-instructions.h
M src/ia32/builtins-ia32.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/macro-assembler-ia32.cc
M src/mips/builtins-mips.cc
M src/mips/code-stubs-mips.cc
M src/mips/full-codegen-mips.cc
M src/mips/lithium-codegen-mips.cc
M src/mips/macro-assembler-mips.cc
M src/parser.cc
M src/runtime.h
M src/runtime.cc
M src/serialize.cc
M src/x64/builtins-x64.cc
M src/x64/code-stubs-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x64/macro-assembler-x64.cc
M src/x87/builtins-x87.cc
M src/x87/code-stubs-x87.cc
M src/x87/full-codegen-x87.cc
M src/x87/lithium-codegen-x87.cc
M src/x87/macro-assembler-x87.cc
M test/fuzz-natives/fuzz-natives.status
A + test/mjsunit/runtime-gen/numbertostringrt.js
A + test/mjsunit/runtime-gen/regexpconstructresult.js
A + test/mjsunit/runtime-gen/regexpexecrt.js
A + test/mjsunit/runtime-gen/stringcharcodeatrt.js
M tools/generate-runtime-tests.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
