I think it's much better now. lgtm with nits:
https://codereview.chromium.org/351893003/diff/20001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/351893003/diff/20001/src/heap.cc#newcode1988
src/heap.cc:1988: AllocationResult allocation;
Move this closer to the usages.
https://codereview.chromium.org/351893003/diff/20001/src/heap.cc#newcode1998
src/heap.cc:1998: if (!allocation.IsRetry()) {
To be uniform:
HeapObject* target = NULL;
if (allocation.To(&target)) {
https://codereview.chromium.org/351893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
